<html>
<head><meta charset="utf-8"><title>Did I break it? · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html">Did I break it?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220592239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592239">(Dec 21 2020 at 15:03)</a>:</h4>
<p>Can anyone test that a <code>master</code>-built RA is still working? Mine just sits there saying "Rust Analyzer is still loading"</p>



<a name="220592318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592318">(Dec 21 2020 at 15:04)</a>:</h4>
<p><span class="user-mention" data-user-id="203546">@Laurențiu Nicola</span> vscode version?</p>



<a name="220592343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592343">(Dec 21 2020 at 15:04)</a>:</h4>
<p>1.52.1</p>



<a name="220592372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592372">(Dec 21 2020 at 15:04)</a>:</h4>
<p>Like.. it was working earlier and I don't have any local changes</p>



<a name="220592628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Florian Diebold <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592628">(Dec 21 2020 at 15:07)</a>:</h4>
<p>mine is working in Emacs</p>



<a name="220592666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592666">(Dec 21 2020 at 15:07)</a>:</h4>
<p>working for me in vscode as well with 1.52.1</p>



<a name="220592959"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220592959" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220592959">(Dec 21 2020 at 15:10)</a>:</h4>
<p><span aria-label="scream" class="emoji emoji-1f631" role="img" title="scream">:scream:</span></p>



<a name="220593612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220593612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220593612">(Dec 21 2020 at 15:16)</a>:</h4>
<p>So it works after a reboot... <span aria-label="confused" class="emoji emoji-1f615" role="img" title="confused">:confused:</span></p>



<a name="220593698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220593698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220593698">(Dec 21 2020 at 15:17)</a>:</h4>
<p><span class="user-mention" data-user-id="203546">@Laurențiu Nicola</span> no worries, I have your back, <strong>I</strong> broke it: <a href="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/VS.20Code.20requirement.20is.20too.20high/near/220592392">https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/VS.20Code.20requirement.20is.20too.20high/near/220592392</a> :D</p>



<a name="220683358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683358">(Dec 22 2020 at 12:16)</a>:</h4>
<p>Oof, I permanently broke CI :(. I merged that release PR manually and <code>xtask tidy</code> complains about a non-bors commit in the history.</p>



<a name="220683602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683602">(Dec 22 2020 at 12:20)</a>:</h4>
<div class="codehilite"><pre><span></span><code>$ git pr
Current branch master is up to date.
$ git rev-list --merges --invert-grep --author &#39;bors\[bot\]&#39; HEAD~19..
$
</code></pre></div>



<a name="220683605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683605">(Dec 22 2020 at 12:20)</a>:</h4>
<p>Hmm</p>



<a name="220683659"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683659" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683659">(Dec 22 2020 at 12:21)</a>:</h4>
<p><a href="/user_uploads/4715/ZcFQZSBcNcwx-OGKMz5WnWuB/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/ZcFQZSBcNcwx-OGKMz5WnWuB/image.png" title="image.png"><img src="/user_uploads/4715/ZcFQZSBcNcwx-OGKMz5WnWuB/image.png"></a></div>



<a name="220683663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683663">(Dec 22 2020 at 12:21)</a>:</h4>
<p>I don't get it</p>



<a name="220683833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220683833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220683833">(Dec 22 2020 at 12:24)</a>:</h4>
<p><a href="/user_uploads/4715/p7AtLQCFK6ZMSQQArbnQBvfu/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/p7AtLQCFK6ZMSQQArbnQBvfu/image.png" title="image.png"><img src="/user_uploads/4715/p7AtLQCFK6ZMSQQArbnQBvfu/image.png"></a></div>



<a name="220685489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220685489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220685489">(Dec 22 2020 at 12:49)</a>:</h4>
<div class="codehilite"><pre><span></span><code>rust-analyzer on  master [⇡$] via  v1.48.0-nightly
❯ git rev-list --merges --invert-grep --author &#39;bors\[bot\]&#39; HEAD~19..
02d8cf82ca3ae8f78a642e5c5afc3ade02caa300
</code></pre></div>
<p>I do get a commit when invoking the command after pulling latest master</p>



<a name="220685517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220685517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220685517">(Dec 22 2020 at 12:49)</a>:</h4>
<p>xtask also fails for me</p>



<a name="220686511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220686511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220686511">(Dec 22 2020 at 13:02)</a>:</h4>
<p>Ah, my <code>master</code> branch was tracking my fork. But I still don't know how to fix it.</p>



<a name="220687189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687189">(Dec 22 2020 at 13:11)</a>:</h4>
<p>The only way I see  to fix this would be to remove the merge via force push, which sounds less than ideal</p>



<a name="220687216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687216">(Dec 22 2020 at 13:11)</a>:</h4>
<p>This also means CI will always break if bors isnt the one that merged doesn't it</p>



<a name="220687221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687221">(Dec 22 2020 at 13:11)</a>:</h4>
<p>Or to quickly merge 20 pull requests</p>



<a name="220687289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Lukas Wirth <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687289">(Dec 22 2020 at 13:12)</a>:</h4>
<p>But that would require bors to merge them all, and since CI fails bors won't merge them will it <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="220687305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687305">(Dec 22 2020 at 13:12)</a>:</h4>
<p>force-pushed</p>



<a name="220687329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687329">(Dec 22 2020 at 13:12)</a>:</h4>
<p>If we force-push quickly it shouldn't cause issues</p>



<a name="220687430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687430">(Dec 22 2020 at 13:14)</a>:</h4>
<p>Filed another PR</p>



<a name="220687458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687458">(Dec 22 2020 at 13:14)</a>:</h4>
<p>So is there a way to <code>merge --ff-only</code> it from the GitHub UI? Does "Rebase and merge" do that?</p>



<a name="220687490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687490">(Dec 22 2020 at 13:15)</a>:</h4>
<p>No, I don't think there is</p>



<a name="220687498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687498">(Dec 22 2020 at 13:15)</a>:</h4>
<p>Why doesn't bors work?</p>



<a name="220687509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687509">(Dec 22 2020 at 13:15)</a>:</h4>
<p>Wait, bors just started with <a href="https://github.com/rust-analyzer/rust-analyzer/pull/6989">https://github.com/rust-analyzer/rust-analyzer/pull/6989</a></p>



<a name="220687544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687544">(Dec 22 2020 at 13:16)</a>:</h4>
<p>Hah, yeah</p>



<a name="220687651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687651">(Dec 22 2020 at 13:17)</a>:</h4>
<p><span class="user-mention silent" data-user-id="211727">Jonas Schievink</span> <a href="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Did.20I.20break.20it.3F/near/220687498">said</a>:</p>
<blockquote>
<p>Why doesn't bors work?</p>
</blockquote>
<p>It used to not work on PRs with workflow changes or that would merge over other workflow changes (e.g. you filed a PR, then the workflows changed on <code>master</code>). It would time out or not run at all.</p>



<a name="220687719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687719">(Dec 22 2020 at 13:18)</a>:</h4>
<p>oh, weird. I'd expect that to work fine.</p>



<a name="220687729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jonas Schievink  [he/him] <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687729">(Dec 22 2020 at 13:18)</a>:</h4>
<p>bors doesn't even look at workflow files</p>



<a name="220687730"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687730" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687730">(Dec 22 2020 at 13:18)</a>:</h4>
<p>I think it was a permissions issue (integrations not being able to modify workflows)</p>



<a name="220687742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687742">(Dec 22 2020 at 13:18)</a>:</h4>
<p>But it might be working fine now, I remember seeing it merge (only) one PR</p>



<a name="220687896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220687896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220687896">(Dec 22 2020 at 13:20)</a>:</h4>
<p><a href="/user_uploads/4715/1vLUKaWx2fpSc5MBdLrsOfWR/image.png">image.png</a>  weee</p>
<div class="message_inline_image"><a href="/user_uploads/4715/1vLUKaWx2fpSc5MBdLrsOfWR/image.png" title="image.png"><img src="/user_uploads/4715/1vLUKaWx2fpSc5MBdLrsOfWR/image.png"></a></div>



<a name="220700237"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220700237" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220700237">(Dec 22 2020 at 15:23)</a>:</h4>
<p>Regarding force pushes -- imo, they are totally OK and overly-demonized. It's like <code>usnafe</code> -- ok, if you know what you are doing</p>



<a name="220700299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220700299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220700299">(Dec 22 2020 at 15:23)</a>:</h4>
<p>So feel free to <code>push --force-with-lease</code> if you need to (but you should understand the difference between <code>--force</code> &amp; <code>--force-with-lease</code> ;) )</p>



<a name="220701472"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220701472" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220701472">(Dec 22 2020 at 15:33)</a>:</h4>
<p>My university completely disabled force pushes even when you disable branch protection by using a push hook. I once had to switch the default branch, delete the original default branch and then recreate it without the commit I wanted to remove.</p>



<a name="220701617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220701617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220701617">(Dec 22 2020 at 15:35)</a>:</h4>
<p>And yes, <code>--force-with-lease</code> is much better than <code>--force</code>. <code>--force-with-lease</code> should really have been called <code>--force</code> and <code>--force</code> <code>--really-really-force-this-action</code>.</p>



<a name="220702098"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220702098" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220702098">(Dec 22 2020 at 15:39)</a>:</h4>
<p>To be fair, this <em>used</em> to be reasonable-ish: previously, git defaulted to pushing <em>all</em> branches, and not only the current one, and using <code>--force</code> with <em>that</em> was problematic</p>



<a name="220702118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220702118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220702118">(Dec 22 2020 at 15:39)</a>:</h4>
<p>IIRC, <code>--force-with-lease</code> will become default in some future git version</p>



<a name="220702198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220702198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220702198">(Dec 22 2020 at 15:40)</a>:</h4>
<p>Also:</p>
<blockquote>
<p>Some editors like Microsoft's VSC have a feature to auto-fetch in the background, this bypasses the protections offered by <code>--force-with-lease</code></p>
</blockquote>



<a name="220702284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Did%20I%20break%20it%3F/near/220702284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Did.20I.20break.20it.3F.html#220702284">(Dec 22 2020 at 15:41)</a>:</h4>
<p>I have that disabled.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>